Skip to content

[main] Source code updates from dotnet/dotnet #11023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 11, 2025
Merged

[main] Source code updates from dotnet/dotnet #11023

merged 12 commits into from
Aug 11, 2025
+485 −838

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 1, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Updated Dependencies

  • From 10.0.0-beta.25377.103 to 10.0.0-beta.25409.103
    • Microsoft.DotNet.Arcade.Sdk
    • Microsoft.DotNet.CodeAnalysis
    • Microsoft.DotNet.GenAPI
    • Microsoft.DotNet.Helix.Sdk
    • Microsoft.SourceLink.AzureRepos.Git
    • Microsoft.SourceLink.GitHub
  • From 10.0.0-preview.7.25377.103 to 10.0.0-rc.1.25409.103
    • Microsoft.Dotnet.WinForms.ProjectTemplates
    • Microsoft.NETCore.App.Ref
    • Microsoft.NETCore.Platforms
    • Microsoft.Private.Winforms
    • System.CodeDom
    • System.Configuration.ConfigurationManager
    • System.Diagnostics.EventLog
    • System.DirectoryServices
    • System.Drawing.Common
    • System.Formats.Nrbf
    • System.IO.Packaging
    • System.Reflection.MetadataLoadContext
    • System.Resources.Extensions
    • System.Runtime.Serialization.Formatters
    • System.Security.Cryptography.Xml
    • System.Security.Permissions
    • System.Windows.Extensions
Microsoft Reviewers: Open in CodeFlow

Associated changes in source repos

dotnet-maestro bot added 2 commits August 1, 2025 20:21
@dotnet-maestro
Backflow from https://github.com/dotnet/dotnet / 8b29a16 build 277635
b330ff9 
[[ commit created by automation ]]
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 277635
dca0d08 
Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.Helix.Sdk, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.GitHub (Version 10.0.0-beta.25377.103 -> 10.0.0-beta.25401.103)
Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Private.Winforms, System.CodeDom, System.Configuration.ConfigurationManager, System.Diagnostics.EventLog, System.DirectoryServices, System.Drawing.Common, System.Formats.Nrbf, System.IO.Packaging, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Runtime.Serialization.Formatters, System.Security.Cryptography.Xml, System.Security.Permissions, System.Windows.Extensions (Version 10.0.0-preview.7.25377.103 -> 10.0.0-rc.1.25401.103)
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner August 1, 2025 20:21
dotnet-policy-service[bot]
dotnet-policy-service bot previously approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 1, 2025
harshit7962
harshit7962 previously approved these changes Aug 4, 2025
View reviewed changes
@harshit7962 harshit7962 dismissed stale reviews from dotnet-policy-service[bot] and themself via f6fa723 August 4, 2025 06:49
@harshit7962
Copy link
Member

@mmitche The failure here is due to the updated version of MicrosoftSourceLinkGitHubVersion. Apparently we are still using 8.0.0-beta.23409.2 instead of the incoming 10.0.0-beta.25401.103. Is it okay to change the given version back to the original? If so, how do we stop it from updating in the future dependency updates?

Talking about the package defined here

dotnet-maestro bot added 2 commits August 6, 2025 02:08
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 278022
2291e73 
Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.Helix.Sdk, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.GitHub (Version 10.0.0-beta.25401.103 -> 10.0.0-beta.25405.103)
Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Private.Winforms, System.CodeDom, System.Configuration.ConfigurationManager, System.Diagnostics.EventLog, System.DirectoryServices, System.Drawing.Common, System.Formats.Nrbf, System.IO.Packaging, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Runtime.Serialization.Formatters, System.Security.Cryptography.Xml, System.Security.Permissions, System.Windows.Extensions (Version 10.0.0-rc.1.25401.103 -> 10.0.0-rc.1.25405.103)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 278224
93b4cb1 
Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.Helix.Sdk, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.GitHub (Version 10.0.0-beta.25405.103 -> 10.0.0-beta.25406.102)
Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Private.Winforms, System.CodeDom, System.Configuration.ConfigurationManager, System.Diagnostics.EventLog, System.DirectoryServices, System.Drawing.Common, System.Formats.Nrbf, System.IO.Packaging, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Runtime.Serialization.Formatters, System.Security.Cryptography.Xml, System.Security.Permissions, System.Windows.Extensions (Version 10.0.0-rc.1.25405.103 -> 10.0.0-rc.1.25406.102)
@premun
Copy link
Member

premun commented Aug 7, 2025

@harshit7962 you can configure the codeflow subscription with darc:

darc update-subscription --id f1124ab6-1481-4f33-a146-eb9bc5b1b331

And you can specify the package in ExcludedAssets, like so:

Excluded Assets:
- Microsoft.SourceLink.GitHub

@akoeplinger
Copy link
Member

A couple .vcxproj added this dummy version of the target, maybe it needs to be added to more projects now with the new sourcelink version:

wpf/src/Microsoft.DotNet.Wpf/src/System.Printing/System.Printing.vcxproj

Lines 235 to 240 in 4bd6464

<Target Name="InitializeSourceControlInformationFromSourceControlManager">
<PropertyGroup>
<SourceRevisionId>$(BUILD_SOURCEVERSION)</SourceRevisionId>
<SourceRevisionId Condition="'$(SourceRevisionId)' == ''">unknownrev</SourceRevisionId>
</PropertyGroup>
</Target>

dotnet-maestro bot added 2 commits August 8, 2025 02:14
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 278405
cbb7499 
Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.Helix.Sdk, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.GitHub (Version 10.0.0-beta.25406.102 -> 10.0.0-beta.25407.105)
Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Private.Winforms, System.CodeDom, System.Configuration.ConfigurationManager, System.Diagnostics.EventLog, System.DirectoryServices, System.Drawing.Common, System.Formats.Nrbf, System.IO.Packaging, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Runtime.Serialization.Formatters, System.Security.Cryptography.Xml, System.Security.Permissions, System.Windows.Extensions (Version 10.0.0-rc.1.25406.102 -> 10.0.0-rc.1.25407.105)
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 278512
d4fbd7e 
Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.Helix.Sdk, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.GitHub (Version 10.0.0-beta.25407.105 -> 10.0.0-beta.25407.104)
Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Private.Winforms, System.CodeDom, System.Configuration.ConfigurationManager, System.Diagnostics.EventLog, System.DirectoryServices, System.Drawing.Common, System.Formats.Nrbf, System.IO.Packaging, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Runtime.Serialization.Formatters, System.Security.Cryptography.Xml, System.Security.Permissions, System.Windows.Extensions (Version 10.0.0-rc.1.25407.105 -> 10.0.0-rc.1.25407.104)
@harshit7962
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

dotnet-maestro bot and others added 3 commits August 11, 2025 02:07
@dotnet-maestro
Update dependencies from https://github.com/dotnet/dotnet build 278626
8d7881c 
Updated Dependencies:
Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.Helix.Sdk, Microsoft.SourceLink.AzureRepos.Git, Microsoft.SourceLink.GitHub (Version 10.0.0-beta.25407.104 -> 10.0.0-beta.25409.103)
Microsoft.Dotnet.WinForms.ProjectTemplates, Microsoft.NETCore.App.Ref, Microsoft.NETCore.Platforms, Microsoft.Private.Winforms, System.CodeDom, System.Configuration.ConfigurationManager, System.Diagnostics.EventLog, System.DirectoryServices, System.Drawing.Common, System.Formats.Nrbf, System.IO.Packaging, System.Reflection.MetadataLoadContext, System.Resources.Extensions, System.Runtime.Serialization.Formatters, System.Security.Cryptography.Xml, System.Security.Permissions, System.Windows.Extensions (Version 10.0.0-rc.1.25407.104 -> 10.0.0-rc.1.25409.103)
@harshit7962
Pinning the back version of MicrosoftSourceLinkGithubPackageVersion
396dd25
@ViktorHofer
Correctly pin sourcelink dependencies
f8582bb
@ViktorHofer
Copy link
Member

@harshit7962 I pinned the dependencies correctly in Version.Details.xml (as the Version.Details.props file is auto-generated and your change would have got overwritten by the next dependency update). Please approve the PR.

@dotnet-maestro dotnet-maestro bot merged commit bd4acbb into main Aug 11, 2025
14 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-main-99543746-55d6-47cf-bc82-07ba9905e2b1 branch August 11, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@harshit7962 harshit7962 harshit7962 approved these changes

@dotnet-policy-service dotnet-policy-service[bot] dotnet-policy-service[bot] left review comments

@dipeshmsft dipeshmsft Awaiting requested review from dipeshmsft

Assignees
No one assigned
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshit7962 @premun @akoeplinger @ViktorHofer